Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEMO] pre-commit and pre-commit-ci #33

Closed
wants to merge 0 commits into from

Conversation

aucampia
Copy link
Owner

Add pre-commit and pre-commit-ci with the following hooks:

  • pycln for cleaning up unused imports.
  • isort for sorinting imports.
  • black for formatting code.
  • check-yaml for validating yaml files.

For more info see docs/developers.rst.

Also:

  • Changed tox config:
    • Added environments for pre-commit.
    • Removed some redudant options.
    • Created a covreport environment for reporting coverage for all
      environments.
    • Make it possible to run a custom command instead of pytest.
    • Make it possible to run an extra command
    • Make it possible to change the mypy command
    • Use extras instead of using requirements files.
  • Update setup.py
    • Remove berkleydb and networkx from tests_require and tests extra
      group as they are not always needed for tests.
    • Added seperate extra groups for berkleydb and networkx
    • Added a dev extras group with dev tools.
  • Update github actions
    • Use tox to run tests.
    • Run flake8 only once.
    • Change docs job to rather be more generic for potential future tox
      environments.

@aucampia
Copy link
Owner Author

pre-commit.ci run

@aucampia
Copy link
Owner Author

pre-commit.ci autofix

@aucampia aucampia force-pushed the master branch 2 times, most recently from 77f680e to c6eccdc Compare January 21, 2022 16:13
@aucampia aucampia force-pushed the iwana-20220116T1355-precommit_ci_demo branch from b774757 to dd82991 Compare January 22, 2022 19:34
@aucampia aucampia closed this Jan 22, 2022
@aucampia aucampia force-pushed the iwana-20220116T1355-precommit_ci_demo branch from dd82991 to d3f9453 Compare January 22, 2022 19:35
@aucampia aucampia deleted the iwana-20220116T1355-precommit_ci_demo branch January 22, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant