Build plugins with -fvisibility=hidden.

acinclude.m4

@@ -116,6 +116,26 @@ if test $HAVE_MSWINDOWS = yes ; then
 	CFLAGS="$CFLAGS -march=i686"
 fi
 
+dnl Byte order
+dnl ==========
+AC_C_BIGENDIAN([BIGENDIAN=1], [BIGENDIAN=0],
+ [AC_MSG_ERROR([Unknown machine byte order])],
+ [AC_MSG_ERROR([Universal builds are not supported, sorry])])
+AC_SUBST([BIGENDIAN])
+
+dnl Prevent symbol collisions
+dnl =========================
+if test "x$HAVE_MSWINDOWS" = "xyes" ; then
+    EXPORT="__declspec(dllexport)"
+elif test "x$GCC" = "xyes" ; then
+    CFLAGS="$CFLAGS -fvisibility=hidden"
+    CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+    EXPORT="__attribute__((visibility(\"default\")))"
+else
+    AC_MSG_ERROR([Unknown syntax for EXPORT keyword])
+fi
+AC_DEFINE_UNQUOTED([EXPORT], [$EXPORT], [Define to compiler syntax for public symbols])
+
 dnl Checks for various programs
 dnl ===========================
 AC_PROG_LN_S

src/asx/asx.cc

@@ -48,7 +48,7 @@ class ASXLoader : public PlaylistPlugin
     static void handle_entry (const char * key, const char * value, void * data);
 };
 
-ASXLoader aud_plugin_instance;
+EXPORT ASXLoader aud_plugin_instance;
 
 void ASXLoader::handle_heading (const char * heading, void * data)
 {

src/asx3/asx3.cc

@@ -42,7 +42,7 @@ class ASX3Loader : public PlaylistPlugin
      const Index<PlaylistAddItem> & items);
 };
 
-ASX3Loader aud_plugin_instance;
+EXPORT ASX3Loader aud_plugin_instance;
 
 static int read_cb (void * file, char * buf, int len)
 {

src/audpl/audpl.cc

@@ -52,7 +52,7 @@ class AudPlaylistLoader : public PlaylistPlugin
     static void handle_entry (const char * key, const char * value, void * data);
 };
 
-AudPlaylistLoader aud_plugin_instance;
+EXPORT AudPlaylistLoader aud_plugin_instance;
 
 void AudPlaylistLoader::finish_item (LoadState * state)
 {

src/blur_scope/blur_scope.cc

@@ -86,7 +86,7 @@ class BlurScope : public VisPlugin
     uint32_t * image = nullptr, * corner = nullptr;
 };
 
-BlurScope aud_plugin_instance;
+EXPORT BlurScope aud_plugin_instance;
 
 bool BlurScope::init ()
 {

src/bs2b/plugin.cc

@@ -48,7 +48,7 @@ class BS2BPlugin : public EffectPlugin
     void process (float * * data, int * samples);
 };
 
-BS2BPlugin aud_plugin_instance;
+EXPORT BS2BPlugin aud_plugin_instance;
 
 static t_bs2bdp bs2b = nullptr;
 static int bs2b_channels;

src/cairo-spectrum/cairo-spectrum.cc

@@ -52,7 +52,7 @@ class CairoSpectrum : public VisPlugin
     void render_freq (const float * freq);
 };
 
-CairoSpectrum aud_plugin_instance;
+EXPORT CairoSpectrum aud_plugin_instance;
 
 static GtkWidget * spect_widget = nullptr;
 static float xscale[MAX_BANDS + 1];

src/compressor/compressor.cc

@@ -80,7 +80,7 @@ class Compressor : public EffectPlugin
     int adjust_delay (int delay);
 };
 
-Compressor aud_plugin_instance;
+EXPORT Compressor aud_plugin_instance;
 
 static float * buffer, * output, * peaks;
 static int output_size;

src/crossfade/crossfade.cc

@@ -77,7 +77,7 @@ class Crossfade : public EffectPlugin
     int adjust_delay (int delay);
 };
 
-Crossfade aud_plugin_instance;
+EXPORT Crossfade aud_plugin_instance;
 
 static char state = STATE_OFF;
 static int current_channels = 0, current_rate = 0;

src/crystalizer/crystalizer.cc

@@ -59,7 +59,7 @@ class Crystalizer : public EffectPlugin
     void flush ();
 };
 
-Crystalizer aud_plugin_instance;
+EXPORT Crystalizer aud_plugin_instance;
 
 static int cryst_channels;
 static float * cryst_prev;

src/cue/cue.cc

@@ -42,7 +42,7 @@ class CueLoader : public PlaylistPlugin
      Index<PlaylistAddItem> & items);
 };
 
-CueLoader aud_plugin_instance;
+EXPORT CueLoader aud_plugin_instance;
 
 static const struct {
     int tuple_type;

src/echo_plugin/echo.cc

@@ -60,7 +60,7 @@ class EchoPlugin : public EffectPlugin
     void process (float * * data, int * samples);
 };
 
-EchoPlugin aud_plugin_instance;
+EXPORT EchoPlugin aud_plugin_instance;
 
 static float *buffer = nullptr;
 static int w_ofs;

src/gio/gio.cc

@@ -354,4 +354,4 @@ static const char * const gio_schemes[] = {"ftp", "sftp", "smb"};
 
 constexpr PluginInfo gio_info = {N_("GIO Plugin"), PACKAGE, gio_about};
 
-TransportPlugin aud_plugin_instance (gio_info, gio_schemes, gio_fopen);
+EXPORT TransportPlugin aud_plugin_instance (gio_info, gio_schemes, gio_fopen);

src/gl-spectrum/gl-spectrum.cc

@@ -74,7 +74,7 @@ class GLSpectrum : public VisPlugin
     void render_freq (const float * freq);
 };
 
-GLSpectrum aud_plugin_instance;
+EXPORT GLSpectrum aud_plugin_instance;
 
 static float logscale[NUM_BANDS + 1];
 static float colors[NUM_BANDS][NUM_BANDS][3];

src/gtkui/ui_gtk.cc

@@ -107,7 +107,7 @@ class GtkUI : public IfacePlugin
         { audgui_plugin_menu_remove (id, func); }
 };
 
-GtkUI aud_plugin_instance;
+EXPORT GtkUI aud_plugin_instance;
 
 static PluginHandle * search_tool;
 

src/ladspa/plugin.cc

@@ -557,4 +557,4 @@ static const PreferencesWidget ladspa_widgets[] = {
 
 const PluginPreferences ladspa_prefs = {{ladspa_widgets}};
 
-LADSPAHost aud_plugin_instance;
+EXPORT LADSPAHost aud_plugin_instance;

src/m3u/m3u.cc

@@ -39,7 +39,7 @@ class M3ULoader : public PlaylistPlugin
      const Index<PlaylistAddItem> & items);
 };
 
-M3ULoader aud_plugin_instance;
+EXPORT M3ULoader aud_plugin_instance;
 
 static void strip_char (char * text, char c)
 {

src/mms/mms.cc

@@ -185,4 +185,4 @@ static const char * const mms_schemes[] = {"mms"};
 
 constexpr PluginInfo mms_info = {N_("MMS Plugin"), PACKAGE};
 
-TransportPlugin aud_plugin_instance (mms_info, mms_schemes, mms_fopen);
+EXPORT TransportPlugin aud_plugin_instance (mms_info, mms_schemes, mms_fopen);

src/mpg123/mpg123.cc

@@ -23,6 +23,10 @@
 
 #include <mpg123.h>
 
+// mpg123.h redefines EXPORT
+#undef EXPORT
+#include "config.h"
+
 #ifdef DEBUG_MPG123_IO
 # define MPG123_IODBG(...)  AUDDBG(__VA_ARGS__)
 #else

src/neon/neon.cc

@@ -106,7 +106,7 @@ class NeonTransport : public TransportPlugin
     void cleanup ();
 };
 
-NeonTransport aud_plugin_instance;
+EXPORT NeonTransport aud_plugin_instance;
 
 bool NeonTransport::init ()
 {

src/pls/pls.cc

@@ -52,7 +52,7 @@ class PLSLoader : public PlaylistPlugin
     static void handle_entry (const char * key, const char * value, void * data);
 };
 
-PLSLoader aud_plugin_instance;
+EXPORT PLSLoader aud_plugin_instance;
 
 void PLSLoader::handle_heading (const char * heading, void * data)
 {

src/qtui/qtui.cc

@@ -74,4 +74,4 @@ class QtUI : public audqt::QtIfacePlugin
     }
 };
 
-QtUI aud_plugin_instance;
+EXPORT QtUI aud_plugin_instance;

src/skins/plugin.cc

@@ -86,7 +86,7 @@ class SkinnedUI : public IfacePlugin
         { audgui_plugin_menu_remove (id, func); }
 };
 
-SkinnedUI aud_plugin_instance;
+EXPORT SkinnedUI aud_plugin_instance;
 
 char * skins_paths[SKINS_PATH_COUNT];
 

src/xspf/xspf.cc

@@ -96,7 +96,7 @@ class XSPFLoader : public PlaylistPlugin
      const Index<PlaylistAddItem> & items);
 };
 
-XSPFLoader aud_plugin_instance;
+EXPORT XSPFLoader aud_plugin_instance;
 
 static void xspf_add_file (xmlNode * track, const char * filename,
  const char * base, Index<PlaylistAddItem> & items)