Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flac: Make Ogg FLAC support optional. Closes: #1181 #110

Conversation

radioactiveman
Copy link
Member

If Ogg FLAC support is available depends on how the
FLAC library was compiled (-DWITH_OGG=ON/OFF).

See also: https://xiph.org/flac/api/group__flac__stream__decoder.html#details

If Ogg FLAC support is available depends on how the
FLAC library was compiled (-DWITH_OGG=ON/OFF).

See also: https://xiph.org/flac/api/group__flac__stream__decoder.html#details
Copy link
Member

@jlindgren90 jlindgren90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not bother creating the ogg_flac_decoder at all if FLAC_API_SUPPORTS_OGG_FLAC is false.

Other than that, LGTM.

@jlindgren90
Copy link
Member

I cherry-picked and cleaned up the decoder initialization with b40dcee. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants