Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audb.Dependencies.__eq__() #381

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Add audb.Dependencies.__eq__() #381

merged 5 commits into from
Mar 26, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Mar 19, 2024

As discussed in #372 (review) it would be nice to have the __eq__() method for audb.Dependencies to compare two dependency tables.

This pull requests implements audb.Dependencies.__eq__() by relying on pandas.DataFrame.equals() to compare for equality.

image

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (916c4e9) to head (f923ea3).

Additional details and impacted files
Files Coverage Δ
audb/core/dependencies.py 100.0% <100.0%> (ø)

Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from point below - that I am not getting the motivation of the self-comparisons, this is good to go.

tests/test_dependencies.py Show resolved Hide resolved
tests/test_dependencies.py Show resolved Hide resolved
@hagenw hagenw merged commit c488bd1 into main Mar 26, 2024
9 checks passed
@hagenw hagenw deleted the dependencies-equal branch March 26, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants