-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for float64 in audresample.remix() #17
Conversation
Codecov Report
|
It was introduced to guarantee identical results with devAIce. But I'm fine with replacing it with a numpy function. Now that we allow any data type in |
Before we had a test that compared the output of the library with the audresample/tests/test_remix.py Lines 16 to 17 in 9e83740
I now reverted it and use the C library in the tests. So I would assume we still guarantee identical results with devAIce. |
nice |
Closes #15
Alternative implementation to #16
audresample.remix()
works totally fine with other data types thanfloat32
, so we don't need to restrict it.The reason why it was retricted to float32 before was the usage of
lib.do_mono_mixdown()
from the C library for mixdown, but do we really need to use it?