Fix division by zero in video in bitrate computation code (mastodon#2…

…7129)
audiodude · Oct 23, 2023 · 6bc0610 · 6bc0610
1 parent dffb270
commit 6bc0610
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/paperclip/transcoder.rb b/lib/paperclip/transcoder.rb
@@ -43,7 +43,8 @@ def make
         unless eligible_to_passthrough?(metadata)
           size_limit_in_bits = MediaAttachment::VIDEO_LIMIT * 8
           desired_bitrate = (metadata.width * metadata.height * 30 * BITS_PER_PIXEL).floor
-          maximum_bitrate = (size_limit_in_bits / metadata.duration).floor - 192_000 # Leave some space for the audio stream
+          duration = [metadata.duration, 1].max
+          maximum_bitrate = (size_limit_in_bits / duration).floor - 192_000 # Leave some space for the audio stream
           bitrate = [desired_bitrate, maximum_bitrate].min
 
           @output_options['b:v']     = bitrate