Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds specifying vlans by name instead of id, contrib/vagrant-softlayer-vlans tool to show usable vlans, force_private_ip option, Quick Start guide, Vagrant Cloud support, parallel build support, provision/rebuild/api timeout exposed to user, bump to sl api 2.2.0+ #15

Closed
wants to merge 12 commits into from
Closed

Adds specifying vlans by name instead of id, contrib/vagrant-softlayer-vlans tool to show usable vlans, force_private_ip option, Quick Start guide, Vagrant Cloud support, parallel build support, provision/rebuild/api timeout exposed to user, bump to sl api 2.2.0+ #15

wants to merge 12 commits into from

Conversation

ju2wheels
Copy link
Contributor

Closes #14

@emyl
Copy link
Member

emyl commented Jul 24, 2014

Thanks Julio, I'll try to take a look to it tonight.

@ju2wheels
Copy link
Contributor Author

Added Quick Start guide and Vagrant Cloud support:

@ju2wheels
Add Quick Start guide and Vagrant Cloud support for end users to get …
ee91566 
…up and running quicker.

* closes @lonniev request in audiolize#9 with addition of Quick Start guide
* resolves request for documented config.ssh.pty by @poflynn in # 11
* Note: contrib/vagrantcloud now contains boxes for available SoftLayer OS templates as the Vagrant Cloud account I setup is configured to pull the boxes from GitHub so theres no need to use a paid account.
@ju2wheels ju2wheels changed the title Add specifying vlans by name instead of id, add contrib/vagrant-softlayer-vlans tool to show usable vlans, and add force_private_ip Add specifying vlans by name instead of id, add contrib/vagrant-softlayer-vlans tool to show usable vlans, add force_private_ip, add Quick Start guide, add Vagrant Cloud support Jul 25, 2014
@emyl
Copy link
Member

emyl commented Jul 29, 2014

Julio, thank you for your hard work. If you have some time please take a look to my code comments and let me know 😉

@ju2wheels
Copy link
Contributor Author

Emil, should be good to go now. Let me know if I missed anything.

@ju2wheels
Update docs on vagrant vs sl standards
0dfa65b
@ju2wheels
Enable parallel builds and expose the provision/rebuild timeout for u…
af27d9a 
…ser customization

Note: I tested the object id's of SL API Service instances to ensure each box was creating its own instances so theres no worry here for these to be critical sections in threading.
@ju2wheels
Copy link
Contributor Author

Added parallel builds and expose provision/rebuild timeout for user customization.

Note: I tested the object id's of SL API Service instances to ensure each box was creating its own instances so there is no worry here for these to be critical sections in threading even though SL API doesnt explicitly do thread safe actions and Net::HTTP seems to be non thread safe: Net::HTTP Thread safety.

@ju2wheels ju2wheels changed the title Add specifying vlans by name instead of id, add contrib/vagrant-softlayer-vlans tool to show usable vlans, add force_private_ip, add Quick Start guide, add Vagrant Cloud support Adds specifying vlans by name instead of id, contrib/vagrant-softlayer-vlans tool to show usable vlans, force_private_ip option, Quick Start guide, Vagrant Cloud support, parallel build support, provision/rebuild timeout exposed to user Jul 30, 2014
@ju2wheels ju2wheels mentioned this pull request Jul 30, 2014
Closed
@ju2wheels
Copy link
Contributor Author

  • bump to softlayer_api >= 2.2.0 and related code transition fixes
  • add api_timeout

sl_warden exception handling warrants further review to see if the exception message checks are still valid but otherwise works as expected.

@ju2wheels ju2wheels changed the title Adds specifying vlans by name instead of id, contrib/vagrant-softlayer-vlans tool to show usable vlans, force_private_ip option, Quick Start guide, Vagrant Cloud support, parallel build support, provision/rebuild timeout exposed to user Adds specifying vlans by name instead of id, contrib/vagrant-softlayer-vlans tool to show usable vlans, force_private_ip option, Quick Start guide, Vagrant Cloud support, parallel build support, provision/rebuild/api timeout exposed to user, bump to sl api 2.2.0+ Jul 31, 2014
@emyl
Copy link
Member

emyl commented Jul 31, 2014

Everything about:

  1. Specifying vlans by name
  2. force_private_ip
  3. docs
  4. contrib tools
  5. Vagrant Cloud

Looks good to me. I'd like to prepare a minor release (0.3.2) with these fixes/enhancement.

Instead parallel tasks and SL API bump are major/breaking features that I'd like to implement in a subsequent major release, after appropriate testing.

As this pull request is becoming a little messy, I'm asking if you can:

  • Rebase your work and make a new PR for points 1 - 5.
  • Create separate feature branches and pull requests for parallel tasks, SL API bump and so on.

Many thanks 😉

@ju2wheels
Copy link
Contributor Author

You want bug fixes for the action handler causing #19 in with that first set too? Im finishing that up now.

@ju2wheels ju2wheels closed this Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] Add the ability to specify public/private vlan by name instead of id
3 participants
@ju2wheels @emyl @lonniev