Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace dependency on assert #3

Open
chrisguttandin opened this issue Apr 15, 2021 · 0 comments
Open

replace dependency on assert #3

chrisguttandin opened this issue Apr 15, 2021 · 0 comments

Comments

@chrisguttandin
Copy link

Hi @audioplastic,

thanks for providing this library. I'm a happy user for quite some time. I'm using ooura in the browser and I use webpack to bundle that the code. Up to v4 webpack did automatically include polyfills for the packages which are default packages of Node.js when building bundles for the browser. That's no longer the case in v5 which means ooura can't be used anymore without jumping through some hoops.

Would you welcome a PR which replaces assert with some inline checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant