Skip to content
This repository has been archived by the owner on May 29, 2020. It is now read-only.

Add plugin_status query arg to the enable/disable links in the Automatic Updates column. #48

Merged
merged 1 commit into from Mar 10, 2020

Conversation

pbiron
Copy link
Collaborator

@pbiron pbiron commented Mar 10, 2020

Fixes #46

@pbiron pbiron added the enhancement New feature or request label Mar 10, 2020
@pbiron
Copy link
Collaborator Author

pbiron commented Mar 10, 2020

One thing to note is that if the user is on the Auto-update enabled view and they disable auto-updates for plugin, then the list of plugins on the screen will not be the same before and after the click.

But that is consistent with what core does with row actions. For example, if the user is on the Inactive view, and they click the Activate row action, then the plugin they activated will not be on the screen when it reloads.

@pbiron pbiron requested a review from audrasjb March 10, 2020 22:10
@pbiron pbiron self-assigned this Mar 10, 2020
Copy link
Owner

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, looks good to me 💪

@audrasjb
Copy link
Owner

audrasjb commented Mar 10, 2020

Yeah, I think it deserves a Trac ticket for the existing row actions then 😃

@pbiron pbiron merged commit 4e1834f into master Mar 10, 2020
@pbiron pbiron deleted the add/issue-46 branch March 10, 2020 22:30
@audrasjb audrasjb added this to the 0.2.1 milestone Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable/Disable action links should return the user to the same "view"
2 participants