Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin_status query arg to the enable/disable links in the Automatic Updates column. #48

Merged
merged 1 commit into from Mar 10, 2020

Conversation

@pbiron
Copy link
Collaborator

pbiron commented Mar 10, 2020

Fixes #46

@pbiron pbiron added the enhancement label Mar 10, 2020
@pbiron

This comment has been minimized.

Copy link
Collaborator Author

pbiron commented Mar 10, 2020

One thing to note is that if the user is on the Auto-update enabled view and they disable auto-updates for plugin, then the list of plugins on the screen will not be the same before and after the click.

But that is consistent with what core does with row actions. For example, if the user is on the Inactive view, and they click the Activate row action, then the plugin they activated will not be on the screen when it reloads.

@pbiron pbiron requested a review from audrasjb Mar 10, 2020
@pbiron pbiron self-assigned this Mar 10, 2020
Copy link
Owner

audrasjb left a comment

Good catch, looks good to me 💪

@audrasjb

This comment has been minimized.

Copy link
Owner

audrasjb commented Mar 10, 2020

Yeah, I think it deserves a Trac ticket for the existing row actions then 😃

@pbiron pbiron merged commit 4e1834f into master Mar 10, 2020
@pbiron pbiron deleted the add/issue-46 branch Mar 10, 2020
@audrasjb audrasjb added this to the 0.2.1 milestone Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.