New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test command in favor of tox #480
Remove test command in favor of tox #480
Conversation
Current coverage is
|
@michaeljoseph Do you happen to have time for a review? 😀 |
{[testenv]deps} | ||
mock | ||
deps = {[testenv]deps} | ||
mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this mock
dependency?
Thank you @michaeljoseph and @pydanny for your thorough review 🙇 From what I know codecov reports the coverage for each of the test envs. If I get rid of |
@hackebrot I meant, the generic |
I changed the test env command to also reflect the invocation from the official docs. https://pypi.python.org/pypi/pytest-cov The docs now explain how to run |
deps = | ||
{[testenv]deps} | ||
mock | ||
deps = {[testenv]deps} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could remove these sections entirely now right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Sir! 👌
👍 |
😤 I'll rebase if you think we are all set here. LGTM |
…f-tox Remove test command in favor of tox
The previous ways of doing things was generic. Due to the way tox works, it is not a general solution as we may wish to be able to test an installed version of cookiecutter without using virtualenv. |
This PR introduces a better way of running the test suite. Instead of setting up a
TestCommand
insetup.py
it leaves the dependency management for testing totox
. As a consequence I also removedmock
fromcompat.py
andsetup.py
. From what I know, it was solely used in tests (andgrep
did not report anything else).The steps to run the test suite are as follows:
I updated the contributor docs to reflect this behavior, which fixes #466.
Please let me know your thoughts!
Best
Raphael