New Feature: Package pane functions become a command (pane) and implement snapshot saved. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, awesome! 🎆 LGTM, I'll review it later tonight for merging. |
audreyt
added a commit
that referenced
this pull request
Apr 8, 2015
New Feature: Package pane functions become a command (pane) and implement snapshot saved.
audreyt
added a commit
that referenced
this pull request
Apr 21, 2015
Revert "New Feature: Package pane functions become a command (pane) and implement snapshot saved." This reverts commit 9c676c0. Conflicts: socialcalc-3.js
|
Hi @samejack , sorry for the revert — it seems with this change, loading an existing spreadsheet, insert a new row and pasting some text will clear the spreadsheet. Would you like to see if you can reproduce this error? |
|
I'll check tomorrow, thanks. |
samejack
added a commit
to samejack/ethercalc
that referenced
this pull request
Apr 23, 2015
|
Hello @audreyt, i have fixed this issue. How do i create Pull Request !? Thanks. |
audreyt
added a commit
that referenced
this pull request
Apr 23, 2015
This reverts commit 9771f34. Conflicts: manifest.appcache
audreyt
added a commit
that referenced
this pull request
Apr 23, 2015
|
That's OK, I have manually applied the fix. I'll test it more locally and make a release in a few days. Thanks for the prompt fix! |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.