Regression in 0.4.3

[dfellis]

On OS X using 0.4.3 every file I try to load gives me Error reading the file some_file.js

This appears to be caused by the most recent commit because running git checkout HEAD~1 && npm install and then ln -s that into the repo, it loads perfectly fine.

I suspect an off-by-one error, here, and will make another PR if I can fix it, but I wouldn't mind a simple revert since the OS failing to provide the entire file means the server is probably going to fail, anyways, and this sort of check is overkill for a dynamic language where the developer has no control over memory usage.

Also, in the future could you increment the version number and keep the old one in NPM, though, even if you think its broken? Starting today I want to use webworker-threads in production, but having what I'm installing change after I've specified a hardwired version number is not fun. (Caught this by dumping my node_modules directory and re-installing with --production from scratch before merging my internal PR.)

I'd rather stick with a version with known issues that I know isn't affecting my code and then upgrade to the better version after testing than be automatically updated and not know about it. :)

Thanks again,

David

[audreyt]

Apologies. Would you mind testing 0.4.4 (just uploaded) to ensure that it worked?

Thanks!

[dfellis]

Unfortunately, no. Still get Error reading the file ./webworker.js in my test repo.

[dfellis]

I put the testing code up on GitHub here so you can see what's happening.

[audreyt]

OK, I see what's going on... It's a misuse of fread() in WebWorkerThreads.cc. Please see of 0.4.5 (just released) fixes it?

[dfellis]

Back from lunch. 0.4.5 fixes it. 👍