Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static panel blur does not take the whole screen with multiple monitors #47

Closed
Caliel666 opened this issue Apr 23, 2021 · 33 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Caliel666
Copy link

image

works fine when i switch to a 1080p resolution or use dynamic panel blur, but it's really glitchy even with artifacts hacks on

@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

Could you give me the result of typing Main.panel.width in looking glass (alt+f2, type lg)?
And the result of Main.layoutManager.primaryMonitor.width too, so I make sure I change the right thing

@aunetx aunetx self-assigned this Apr 23, 2021
@aunetx aunetx added the bug Something isn't working label Apr 23, 2021
@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

Last commits should have fixed this, but if not then please tell it to me :)

@Caliel666
Copy link
Author

Caliel666 commented Apr 23, 2021

hello, here's the outputs

image

and last commit didn't do anything, i even tried to change some things in panel.js (140-151) to the exact width and height of my resolution and nothing happened

also changing this.monitor.width to Main.layoutManager.primaryMonitor.width in panel.js didn't change anything

@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

Oh ok, that's a much worse bug than I though... Does your wallpaper resolution match (or exceed) your monitor resolution?
It looks like you are using a 1080p wallpaper, and so when cloning it, the extension does not extend it so it matches the right resolution

@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

I mean, I think, because I can't reproduce this on my machine...

@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

In looking glass, could you tell me the result of those commands:

Main.panel.get_parent().get_child_at_index(0).width
Main.panel.get_parent().get_child_at_index(0).get_child_at_index(0).width

And maybe try these commands, to see if it changes anything:

Main.panel.get_parent().get_child_at_index(0).set_x_expand(true)
Main.panel.get_parent().get_child_at_index(0).get_child_at_index(0).set_x_expand(true)

@Caliel666
Copy link
Author

Caliel666 commented Apr 23, 2021

my wallpaper is waaay bigger then my resolution, but even when changing it to a different one doesn't make the panel look correct

outputs:
image

i think the issue is Main.panel.get_parent().get_child_at_index(0).get_child_at_index(0).width

second output:
image

@Caliel666
Copy link
Author

quick update

i found out that having 2 monitors is the issue, the panel looks correct on the 2560 resolution when disabling my second 1080p monitor

@aunetx aunetx closed this as completed in bb6c568 Apr 23, 2021
@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

Sorry for closing, could you try with latest commit?

@aunetx aunetx reopened this Apr 23, 2021
@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

Sorry again, I did an error... Try with new last commit to this day (597eb90) maybe?

@Caliel666
Copy link
Author

it didn't fix it, but since the problem is when having 2 monitors i think this issue can be closed, it's not related for ultrawide monitors

@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

Ok thanks, I guess I will need to test my extension some little more...
I let this open, but just change its subject! It's not the same as #40 anyway, so I will need two separate issues

@aunetx aunetx changed the title static panel blur doesn't work correctly on a ultrawide monitor Static panel blur does not take the whole screen with multiple monitors Apr 23, 2021
@Caliel666
Copy link
Author

ok!

just to revise the issue, it works perfectly with 2 monitors on a 16:9 resolution, does not work with a 21:9 monitor and a 16:9 dual setup

works perfectly with a single monitor no matter the resolution

@aunetx
Copy link
Owner

aunetx commented Apr 23, 2021

Ok thanks, will test this soon!
Multi-monitor support is actually quite entertaining :)

@ruathudo
Copy link

ruathudo commented May 4, 2021

I confirm this issue happen for me too. To reproduce, you need to have 2 monitors with different resolutions. In my case, the panel is blurred half which is exactly the ratio of 2 monitors.

@aunetx
Copy link
Owner

aunetx commented May 11, 2021

Could you give me the results of:

Main.layoutManager.monitors[0].width
Main.panel.get_parent().get_children()[0].get_children()[0].width
Main.panel.get_parent().get_children()[0].get_children()[0].width


Main.layoutManager.monitors[1].width
Main.panel.get_parent().get_children()[0].get_children()[1].width
Main.panel.get_parent().get_children()[0].get_children()[1].width

So I better understand what happens :)

@Caliel666
Copy link
Author

image

@aunetx
Copy link
Owner

aunetx commented May 11, 2021

Thanks a lot, that's perfect :) will look into this

@aunetx
Copy link
Owner

aunetx commented May 11, 2021

Sorry, could you give me the result of Main.layoutManager.primaryMonitor.index too? Just to make sure of one thing

@Caliel666
Copy link
Author

image
there we go

@aunetx
Copy link
Owner

aunetx commented May 11, 2021

Thanks a lot :)

@aunetx
Copy link
Owner

aunetx commented May 16, 2021

Ok, I get it

@aunetx aunetx closed this as completed in dc24a55 May 16, 2021
@aunetx
Copy link
Owner

aunetx commented May 16, 2021

Is this issue fixed with last commit?

@aunetx aunetx reopened this May 16, 2021
@Caliel666
Copy link
Author

yes! static blur now works as intended with different resolutions on multi monitors, well at least on my setup, thank you!

@aunetx
Copy link
Owner

aunetx commented May 16, 2021

Cool! You're welcome, enjoy :)

@aunetx aunetx closed this as completed May 16, 2021
@guihkx
Copy link

guihkx commented May 22, 2021

Thank you @aunetx, the fix also worked for me. (2 screens, first one 1920x1080, second one 1360x768)

Any plans to release v12 soon? Thanks :)

@aunetx
Copy link
Owner

aunetx commented May 23, 2021

Glad it works for you too :)
And sorry for v12, I did not thinks about it... Will do it tomorrow, when I am on my computer ^^

@mbrla0
Copy link
Contributor

mbrla0 commented May 25, 2021

This issue doesn't seem to be fixed in the latest master in my setup. It only works properly when my primary monitor, the one with higher resolution, is to the left of the secondary monitor, which has a lower resolution.

If I instead put the secondary monitor to the left of my primary one, the static blur cuts off at a width equal to the width of the secondary monitor.

@aunetx
Copy link
Owner

aunetx commented May 26, 2021

It is pushed to gnome extensions, waiting for review.

@DarkRyu550 could you give me the results of this in looking glass, when the extension has bad behaviour?

Main.layoutManager.monitors[0].x
Main.layoutManager.monitors[0].width
Main.panel.get_parent().get_children()[0].get_children()[0].width
Main.panel.get_parent().get_children()[0].get_children()[0].width

Main.layoutManager.monitors[1].x
Main.layoutManager.monitors[1].width
Main.panel.get_parent().get_children()[0].get_children()[1].width
Main.panel.get_parent().get_children()[0].get_children()[1].width

@mbrla0
Copy link
Contributor

mbrla0 commented May 26, 2021

Here are the results.
image

And how it looks, for reference.
image

@mbrla0
Copy link
Contributor

mbrla0 commented May 26, 2021

I seem to have found the bit of code that is responsible for this issue. I'll open a PR to submit my fix.

@aunetx
Copy link
Owner

aunetx commented May 26, 2021

Thanks a lot!!

@JakWai01
Copy link

I also have an issue with this. My main monitor is a 4k one on the left. I also have a 1920x1080 one on the right. If I move the smaller one to the left it works. If the smaller one is on the right, it doesn't.

weblate pushed a commit to weblate/blur-my-shell that referenced this issue Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants