Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 42 since it works there #186

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Bump to 42 since it works there #186

merged 1 commit into from
Feb 21, 2022

Conversation

shemgp
Copy link
Contributor

@shemgp shemgp commented Feb 4, 2022

Tested using Ubuntu Jammy + GNOME PPA with gnome-shell 42.

Prefs works too.

@timocapa
Copy link

timocapa commented Feb 5, 2022

No, it's been broken on main because panel corners have been removed. It'll fail to load with "Main.panel._leftCorner is undefined", probably the same with the right corner.

You could probably easy patch it by removing those functions, but it might break backwards compability.

https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/4f27a6e52056bf1f486b49c2909c94c612c38f75

If you just want to build with G42 once it's broken for you too, this should work (does for me): timocapa@ec5ff24

Dash to Dock also broke due to the same thing.

@aunetx
Copy link
Owner

aunetx commented Feb 9, 2022

Yes, due to the recent changes, this won't work with gnome 42. I will add "some" support for gnome 42 soon (by just verifying that corners exist before blurring them), but final support will only come with #180, which should use libadwaita for the preferences.

@aunetx
Copy link
Owner

aunetx commented Feb 21, 2022

I merge this as #189 got merged too, will push to eog

@aunetx aunetx merged commit 172f7f7 into aunetx:master Feb 21, 2022
pull bot pushed a commit to TheRakeshPurohit/blur-my-shell that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants