Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding standard: Keep /* global */ jslint config in files? #81

Closed
tony opened this issue Aug 14, 2012 · 4 comments
Closed

Coding standard: Keep /* global */ jslint config in files? #81

tony opened this issue Aug 14, 2012 · 4 comments

Comments

@tony
Copy link
Contributor

tony commented Aug 14, 2012

Hi, was passing by and saw oppurtunity to make a pull, but wanted to step back and get a take on this.

Since we're using grunt configuration for handling jslint, we're set to allow for require, define, etc.

As a matter of consistency moving forward, should we include jslint comments at the top of backbone-aura files? It's missing on some, included on others, and outdated in other places.

Best
T

@addyosmani
Copy link
Member

Thanks for stopping by. I'm all for consistency in comments at the top where it makes sense. If you'd like to put together your thoughts in a PR, we'd be happy to discuss further and consider updating :)

@dustinboston
Copy link
Contributor

@tony @addyosmani Additionally, once we get into V2 I'd like to add some more rigorous formatting guidelines and possibly use strict for the same reasons.

@addyosmani
Copy link
Member

Agreed. That would be perfect to get in.

@tony
Copy link
Contributor Author

tony commented Aug 15, 2012

I just opened 2 different pull requests, #82 and #83. One cleans out unused per-file options and globals, the other gets /aura to pass linting. If the requests aren't up to snuff we can close.

Regardless of whether we take those pulls, #22 did mention idiomatic as a coding standard. I'm all for aura being a good example of coding, so creating a doc on conventions contributor's / developers can adhere to would be awesome.

@tony tony closed this as completed Aug 20, 2012
@tony tony mentioned this issue Aug 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants