You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, was passing by and saw oppurtunity to make a pull, but wanted to step back and get a take on this.
Since we're using grunt configuration for handling jslint, we're set to allow for require, define, etc.
As a matter of consistency moving forward, should we include jslint comments at the top of backbone-aura files? It's missing on some, included on others, and outdated in other places.
Best
T
The text was updated successfully, but these errors were encountered:
Thanks for stopping by. I'm all for consistency in comments at the top where it makes sense. If you'd like to put together your thoughts in a PR, we'd be happy to discuss further and consider updating :)
@tony@addyosmani Additionally, once we get into V2 I'd like to add some more rigorous formatting guidelines and possibly use strict for the same reasons.
I just opened 2 different pull requests, #82 and #83. One cleans out unused per-file options and globals, the other gets /aura to pass linting. If the requests aren't up to snuff we can close.
Regardless of whether we take those pulls, #22 did mention idiomatic as a coding standard. I'm all for aura being a good example of coding, so creating a doc on conventions contributor's / developers can adhere to would be awesome.
Hi, was passing by and saw oppurtunity to make a pull, but wanted to step back and get a take on this.
Since we're using grunt configuration for handling jslint, we're set to allow for
require
,define
, etc.As a matter of consistency moving forward, should we include jslint comments at the top of backbone-aura files? It's missing on some, included on others, and outdated in other places.
Best
T
The text was updated successfully, but these errors were encountered: