Widgets path reflux #156
Merged
Widgets path reflux #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core shouldn't use "../../.." to get to widgets. Widgets path should be app-configurable. Also added stub widget module definition to get rid of the RequireJS load error seen with the mediator tests.
|
Really nice work. Agreed with these changes :) |
|
Yay! I'm glad you liked it. And thus I've made my first actual JavaScript contribution to Aura. :) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core shouldn't have an opinion on where the widgets folder lies. Use a path config to point to widgets root. Applications should be able to put their widgets anywhere they want.
Also fixed the RequireJS load error caused by dummy "test" widget by defining a stub module.