-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined offset notice #8
Comments
@harikt I think this should be fix and I am sure it is not so hard to fixing this, is it? ;) |
@sharifzadesina I wonder whether that was a typo in the docs ( have not put the additional star ) . So Below is the fix for the same class MediaValue ....
protected function init()
{
// list($this->type, $this->subtype) = explode('/', $this->value);
$values = explode('/', $this->value);
$this->type = $values[0];
$this->subtype = isset($values[1]) ? $values[1] : '*';
} @pmjones any different thought? |
Thank you @sharifzadesina for linking to the RFC. For reference to others : fixed via #9 . In case of better fixes send a different one. Thank you. |
Add a test case and fix for issue #8 reporting warning
Looks good @harikt ! Thanks, @sharifzadesina , for the report. Fixed in #9 |
Hi
I have tested this example in README.md file. the result is ok but there is a notice.
The text was updated successfully, but these errors were encountered: