4.x with PHP 7.x features #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harikt
commented
Apr 30, 2022
| @@ -32,7 +34,7 @@ class Regex | |||
| * @return bool True if the value was sanitized, false if not. | |||
| * | |||
| */ | |||
| public function __invoke($subject, $field, $expr, $replace) | |||
| public function __invoke(object $subject, string $field, $expr, $replace): bool | |||
There was a problem hiding this comment.
I am wondering whether we need to remove is_scalar check and allow array also to be passed to $exp and $replace .
|
@koriym I am merging this. You can have a look into the PR. There are certain doubts / questions I have.
We can discuss about the changes here. Thank you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.