Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Void helper to VoidTag #53

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Conversation

jakejohns
Copy link
Member

PHP 7.1: Cannot use 'Void' as class name as it is reserved

@pmjones
Copy link
Member

pmjones commented Apr 21, 2017

Technically this is a BC break. Would it be possible to add a class_alias() in there somewhere, instead of renaming the class proper? Or does the class name itself break in 7.1 ?

PHP 7.1: Cannot use 'Void' as class name as it is reserved
@jakejohns
Copy link
Member Author

@pmjones I dont think there's actually been a release with the void helper in it. Does that matter?

use phpunit in require-dev
@pmjones
Copy link
Member

pmjones commented Apr 21, 2017

If there has been no release with the Void helper then there is no BC break from a previous release. :-)

@jakejohns
Copy link
Member Author

  • Last release (2.4.1) is from Mar 27, 2015
  • Void helper was from Mar 19, 2016

Does that mean we can just merge this then?

@pmjones
Copy link
Member

pmjones commented Apr 21, 2017

Press the shiny green button! DO IT!!!

@jakejohns jakejohns merged commit 1498805 into auraphp:2.x Apr 21, 2017
@harikt
Copy link
Member

harikt commented Apr 22, 2017

@jakejohns I believe you will be able to make a release. or do you need anything else ?

@jakejohns
Copy link
Member Author

@harikt I've never made a release on an aura package before. Is there any preferred protocol here? Or just tag the commit and push it? Should I be using producer? I haven't really experimented with producer. For better or worse, my normal workflow is pretty git-flow centric.

@pmjones
Copy link
Member

pmjones commented Apr 26, 2017

@jakejohns Get your hands on https://github.com/auraphp/bin and use the release2 command after setup. I expect the first time to be tricky for you, since it's mostly an internal tool I built for myself and so there's not a lot of nicety there. Please ask questions as you have them.

@jakejohns
Copy link
Member Author

@pmjones Thanks! I'll check is out as soon as I can.

@harikt
Copy link
Member

harikt commented Apr 26, 2017

@jakejohns I was having some notes, but it looks I am missing to see where it is :-( .

This was some of the troubles I came across after https://github.com/auraphp/bin#making-a-2x-release

auraphp/bin#6 , auraphp/bin#7 (comment) . But as Paul mentioned, you can always ask if you are in trouble.

@jakejohns jakejohns mentioned this pull request Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants