-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Void helper to VoidTag #53
Conversation
Technically this is a BC break. Would it be possible to add a class_alias() in there somewhere, instead of renaming the class proper? Or does the class name itself break in 7.1 ? |
PHP 7.1: Cannot use 'Void' as class name as it is reserved
@pmjones I dont think there's actually been a release with the void helper in it. Does that matter? |
use phpunit in require-dev
If there has been no release with the Void helper then there is no BC break from a previous release. :-) |
Does that mean we can just merge this then? |
Press the shiny green button! DO IT!!! |
@jakejohns I believe you will be able to make a release. or do you need anything else ? |
@harikt I've never made a release on an aura package before. Is there any preferred protocol here? Or just tag the commit and push it? Should I be using producer? I haven't really experimented with producer. For better or worse, my normal workflow is pretty git-flow centric. |
@jakejohns Get your hands on https://github.com/auraphp/bin and use the |
@pmjones Thanks! I'll check is out as soon as I can. |
@jakejohns I was having some notes, but it looks I am missing to see where it is :-( . This was some of the troubles I came across after https://github.com/auraphp/bin#making-a-2x-release auraphp/bin#6 , auraphp/bin#7 (comment) . But as Paul mentioned, you can always ask if you are in trouble. |
PHP 7.1: Cannot use 'Void' as class name as it is reserved