New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match method allows null for $server but it's required #24
Comments
Aha! Yes, patch please. Thanks! |
Oh, and no use of $_SERVER; remove the null. |
You've done some really nice work there in Aura. Looking really good. Jon
|
This was fixed in the 1.1.0 release; thanks! |
can we close this @pmjones ? I am closing this, for you mentioned it is fixed in 1.1.0 release. |
public function match($path, array $server = null) {
...
// Then a call to $route->isMatch($path, $server);
}
So, either remove the null or use $_SERVER if null?
I can make a change if you think it's warranted.
J.
The text was updated successfully, but these errors were encountered: