Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match method allows null for $server but it's required #24

Closed
jelofson opened this issue Mar 27, 2013 · 5 comments
Closed

match method allows null for $server but it's required #24

jelofson opened this issue Mar 27, 2013 · 5 comments

Comments

@jelofson
Copy link
Member

public function match($path, array $server = null) {
...
// Then a call to $route->isMatch($path, $server);
}

So, either remove the null or use $_SERVER if null?

I can make a change if you think it's warranted.

J.

@pmjones
Copy link
Member

pmjones commented Mar 27, 2013

Aha! Yes, patch please. Thanks!

@pmjones
Copy link
Member

pmjones commented Mar 27, 2013

Oh, and no use of $_SERVER; remove the null.

@jelofson
Copy link
Member Author

You've done some really nice work there in Aura. Looking really good.

Jon
On Mar 27, 2013 2:30 PM, "pmjones" notifications@github.com wrote:

Aha! Yes, patch please. Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-15551138
.

@pmjones
Copy link
Member

pmjones commented May 21, 2013

This was fixed in the 1.1.0 release; thanks!

@harikt
Copy link
Member

harikt commented May 21, 2013

can we close this @pmjones ? I am closing this, for you mentioned it is fixed in 1.1.0 release.

@harikt harikt closed this as completed May 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants