match method allows null for $server but it's required #24

Closed
jelofson opened this Issue Mar 27, 2013 · 5 comments

Projects

None yet

3 participants

@jelofson
Member

public function match($path, array $server = null) {
...
// Then a call to $route->isMatch($path, $server);
}

So, either remove the null or use $_SERVER if null?

I can make a change if you think it's warranted.

J.

Owner
pmjones commented Mar 27, 2013

Aha! Yes, patch please. Thanks!

Owner
pmjones commented Mar 27, 2013

Oh, and no use of $_SERVER; remove the null.

Member

You've done some really nice work there in Aura. Looking really good.

Jon
On Mar 27, 2013 2:30 PM, "pmjones" notifications@github.com wrote:

Aha! Yes, patch please. Thanks!


Reply to this email directly or view it on GitHubhttps://github.com/auraphp/Aura.Router/issues/24#issuecomment-15551138
.

Owner
pmjones commented May 21, 2013

This was fixed in the 1.1.0 release; thanks!

Member
harikt commented May 21, 2013

can we close this @pmjones ? I am closing this, for you mentioned it is fixed in 1.1.0 release.

@harikt harikt closed this May 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment