-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In readme #6
Comments
In the format
I don't think we need the dot , can we remove that if so ? |
Do we need to create any .htaccess file ? The path http://localhost:8000/blog/read/1 is ok , but when a .html or .json is added it just throws Not Found . |
@pmjones may be you want to investigate into this before we go for next release . I feel its due to my php installation issue , but not sure though. |
Regarding |
There's a bug in Route::isSecureMatch(); it uses = when it should use ==. Fixing and testing now, and adding debugging/logging methods so other problems will be easier to diagnose. |
Fixed, committed, and pushed. Try it again; if you still have trouble, please open a new issue. Thanks HariKT ! |
In the advanced section
method -- The $server['REQUEST_METHOD'] must match one of these values.
secure -- When true the $server['HTTPS']
,I feel its $_SERVER , but as I am confused whether you was trying to represent the variable in signature function over
is_match -- A custom callback or closure with the signature function(array $server, \ArrayObject $matches)
Sample code I tried is not working , confusion over the
format
in documentation . See first example no dot for format , second one has dot for the format . I feel we don't need the dot to be passed . Do you feel so ? Then why ? Normally we say html , atom like so , not .html , .xml etc .I have started the server with
from the default directory . I guess, the error is throwing by Apache and not by Router itself .
The text was updated successfully, but these errors were encountered: