New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastRoute format #196
FastRoute format #196
Conversation
Interesting... Need to look more closely the implementation. Curious to know one thing, if you have time to explain. What all things do you see will help you adding this feature. |
It's easier to integrate with php 8 attributes. |
Cool. I will try to look into this in the weekend if there is any BC breaks. If no we can merge this feature. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpunit 9.x change signature.
Good finding regarding the |
Hey @koriym , Do you see any problem in this PR. It looks good to me. We can merge this if there is no trouble. |
Scrutinizer failed and i don't know why? |
scrutinizer failing is not an issue. We can look into that. |
features: Add FastRoute format to Route path declaration.
Format in path declaration take precedence .
Is it an interesting enhancement?