Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastRoute format #196

Merged
merged 8 commits into from Jun 12, 2023
Merged

FastRoute format #196

merged 8 commits into from Jun 12, 2023

Conversation

willy68
Copy link
Contributor

@willy68 willy68 commented May 7, 2023

features: Add FastRoute format to Route path declaration.

Format in path declaration take precedence .

Is it an interesting enhancement?

@harikt
Copy link
Member

harikt commented May 12, 2023

Interesting... Need to look more closely the implementation.

Curious to know one thing, if you have time to explain. What all things do you see will help you adding this feature.

@harikt harikt requested a review from koriym May 12, 2023 10:30
@willy68
Copy link
Contributor Author

willy68 commented May 12, 2023

It's easier to integrate with php 8 attributes.
ex:
#[Route('/blog/{slug:[a-z-0-9_]+}-{id:[0-9]+}', name:'blog.show', methods:['GET'])]

@harikt
Copy link
Member

harikt commented May 15, 2023

Cool. I will try to look into this in the weekend if there is any BC breaks. If no we can merge this feature.

Thank you.

tests/RouteTest.php Outdated Show resolved Hide resolved
Copy link
Contributor Author

@willy68 willy68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpunit 9.x change signature.

tests/RouteTest.php Outdated Show resolved Hide resolved
tests/Helper/RouteTest.php Outdated Show resolved Hide resolved
@harikt
Copy link
Member

harikt commented May 24, 2023

Good finding regarding the expectException and expectExceptionMessage . I apologize for the delay in merging, but need to make sure there is no issues or BC break. Thank you for your patience.

@harikt
Copy link
Member

harikt commented May 25, 2023

Hey @koriym ,

Do you see any problem in this PR. It looks good to me. We can merge this if there is no trouble.

@willy68
Copy link
Contributor Author

willy68 commented May 25, 2023

Scrutinizer failed and i don't know why?

@harikt
Copy link
Member

harikt commented May 25, 2023

scrutinizer failing is not an issue. We can look into that.

@harikt harikt merged commit 52fc0be into auraphp:3.x Jun 12, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants