Add test coverage #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. |
|
Are you going to send to other repos as well ? |
|
No problem, I can do it. |
|
But if you don't think we need this, we can close this PR. That's not a problem either. |
|
Oh already merged 😅 |
|
I have no problem keeping the badge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to recover the coverage measurement and badge creation that was previously done by scrutinizer, but now it is done by "codecov". (The previous coverage upload from travis to scrutinizer was unstable.)
Even if you don't feel that the coverage measurement is important, doesn't it make sense to keep the package in its original state and to show the code quality?