Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with PHP 8.1 #193

Merged
merged 25 commits into from
Nov 8, 2021
Merged

Compatibility with PHP 8.1 #193

merged 25 commits into from
Nov 8, 2021

Conversation

srjlewis
Copy link
Contributor

Add typing and compatibility with PHP 8.1

I have also pulled in #191

@srjlewis srjlewis mentioned this pull request Oct 28, 2021
Closed
@kenjis
Copy link
Member

kenjis commented Nov 2, 2021

@koriym Can you review?

kenjis
kenjis reviewed Nov 3, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@srjlewis @kenjis
Update composer.json to php 8.1
579e653 
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
kenjis reviewed Nov 3, 2021
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
srjlewis and others added 2 commits November 3, 2021 10:13
@srjlewis @kenjis
Update .github/workflows/tests.yml to only test on with php 8.1
4eb418b 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@srjlewis
Update test for a change in behavior
2eb4485 
By default PDO now uses native types for int/floats instead of everything being strings.
koriym
koriym approved these changes Nov 4, 2021
View reviewed changes
src/ConnectionLocator.php Show resolved Hide resolved
srjlewis
srjlewis commented Nov 4, 2021
View reviewed changes
Copy link
Contributor Author

@srjlewis srjlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a extra test, all looks good

srjlewis and others added 4 commits November 7, 2021 09:02
@srjlewis @kenjis
Update src/PdoInterface.php
9d66473 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@srjlewis @kenjis
Update src/PdoInterface.php
421633f 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@srjlewis @kenjis
Update src/PdoInterface.php
4b84240 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@srjlewis @kenjis
Update src/PdoInterface.php
8de43af 
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/PdoInterface.php Outdated Show resolved Hide resolved
srjlewis and others added 4 commits November 7, 2021 09:10
@srjlewis @kenjis
Update src/PdoInterface.php
48914ec 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@srjlewis @kenjis
Update src/PdoInterface.php
52b5340 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@srjlewis @kenjis
Update src/AbstractExtendedPdo.php
aa574c9 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@srjlewis @kenjis
Apply suggestions from code review
77746c2 
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/PdoInterface.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/PdoInterface.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/PdoInterface.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/PdoInterface.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/PdoInterface.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/PdoInterface.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/PdoInterface.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Nov 7, 2021
View reviewed changes
src/AbstractExtendedPdo.php Outdated Show resolved Hide resolved
@kenjis
Copy link
Member

kenjis commented Nov 7, 2021

Could you update the config file of PHPUnit?

PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 3:
  - Element 'testsuite': The attribute 'name' is required but missing.

  Line 7:
  - Element 'filter': This element is not expected.

  Test results may not be as expected.

@kenjis
Copy link
Member

kenjis commented Nov 8, 2021

We tried to match the PDO method signatures in the PHP manual as much as possible.

@kenjis kenjis merged commit 2c39cd2 into auraphp:5.x Nov 8, 2021
@kenjis
Copy link
Member

kenjis commented Nov 8, 2021

@srjlewis Thank you!

@kenjis kenjis mentioned this pull request Nov 8, 2021
Merged
@srjlewis srjlewis deleted the 5.x-php8.1 branch November 8, 2021 10:07
@kenjis
Copy link
Member

kenjis commented Nov 10, 2021

Close #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis left review comments

@koriym koriym koriym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srjlewis @kenjis @koriym