Fix for issue #96. Allow first bind value of query with numbered placeholders to be null #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed placeholders to be null.
|
(Who the hell is mlaphp? ;-) I say get rid of the isset() entirely and use only array_key_exists(). |
|
@pmjones No problem to get rid of isset. |
|
Good deal! I'll let the CI stuff run and then merge. Thanks! |
|
@pmjones No problem, thank you for the wonderful Aura libraries! ps. I would be happy with a new version, could you tag one? :) |
pmjones
pushed a commit
that referenced
this pull request
Mar 3, 2015
Fix for issue #96. Allow first bind value of query with numbered placeholders to be null
|
2.4.1 is released :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #96 provided with a test.