Simplify package requirements #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, both the README and the Build-Depends of the Debian package require versions of libraries as available in Debian Buster; however, vonsh does not really require them, i.e. it builds fine in Debian Stretch too. Also, some of the packages required for the Debian build are part of the base build-essential set, and thus no need to be specified (unless a specific version is required, which is not the case). Hence, simplify the list of requirements: - do not mention libc6 as requirement: it is the C library, always available - mention the 3 SDL modules by name, not by Debian package name - remove libc6-dev, gcc, g++, make, and dpkg-dev from the build dependencies: any version of them works just fine, and they are part of build-essential - mention build-essential only in the README, so users know what to install - lower the version of debhelper to 9, as it is the compat level requested by debian/compat - drop the version of libsdl2-dev, libsdl2-image-dev, and libsdl2-mixer-dev, as older versions work just fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both the
READMEand theBuild-Dependsof the Debian package require versions of libraries as available in Debian Buster; however, vonsh does not really require them, i.e. it builds fine in Debian Stretch too. Also, some of the packages required for the Debian build are part of the basebuild-essentialset, and thus no need to be specified (unless a specific version is required, which is not the case).Hence, simplify the list of requirements:
libc6as requirement: it is the C library, always availablelibc6-dev,gcc,g++,make, anddpkg-devfrom the build dependencies: any version of them works just fine, and they are part ofbuild-essentialbuild-essentialonly in theREADME, so users know what to installdebhelperto 9, as it is the compat level requested bydebian/compatlibsdl2-dev,libsdl2-image-dev, andlibsdl2-mixer-dev, as older versions work just fine