Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

abt-navbar, fixed-top #46

Closed
shahabganji opened this issue Jan 28, 2018 · 2 comments
Closed

abt-navbar, fixed-top #46

shahabganji opened this issue Jan 28, 2018 · 2 comments
Assignees
@HamedFathi
Labels
enhancement later-on

Comments

@shahabganji
Copy link
Contributor

When we add .fixed-top to the abt-navbar, and then clicking on bt-navbar-dropdown-mega-item there is a gap between navbar and items to be shown.
@aurelia-toolbelt aurelia-toolbelt locked as resolved and limited conversation to collaborators Jan 28, 2018
@shahabganji shahabganji reopened this Jan 28, 2018
@aurelia-toolbelt aurelia-toolbelt unlocked this conversation Jan 28, 2018
HamedFathi added a commit that referenced this issue Jan 28, 2018
@HamedFathi
Fix(bug #46)
970452d 
Update(abt-navbar docs)
Fix(move injectStyles() to .css files)
HamedFathi added a commit that referenced this issue Jan 28, 2018
@HamedFathi
Revert(bugfix #46) needs more investigation
a55575b
@HamedFathi HamedFathi reopened this Jan 28, 2018
@HamedFathi HamedFathi added bug and removed question labels Jan 28, 2018
@HamedFathi
Copy link
Member

HamedFathi commented Jan 28, 2018 •
edited

I need more time for investigation, this gap is because of supporting megamenu beside standard navbar.
We have two choices:

  1. Separate navbar and mega menu.
  2. Find a way to calculating correct top for content.

However, I do not know the gap as a bug because that is fit to navbar with about 1px space, but the fix can be good.

@HamedFathi HamedFathi removed the bug label Jan 28, 2018
@shahabganji
Copy link
Contributor Author

we can get into details later on.

HamedFathi pushed a commit that referenced this issue Jan 29, 2018
fixed(#46, gap removed)
12b9ffb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HamedFathi HamedFathi

Labels
enhancement later-on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shahabganji @HamedFathi