Skip to content

Commit

Permalink
chore(ci): don't bump release version twice
Browse files Browse the repository at this point in the history
  • Loading branch information
fkleuver committed Oct 26, 2019
1 parent b57f1b3 commit 2bf12e4
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ commands:
merge_topic:
type: boolean
default: true
bump_version:
type: boolean
default: true
steps:
- run: set -o pipefail && ./node_modules/.bin/lerna clean -y
- run: set -o pipefail && git add packages/*/dist --force && git status
Expand All @@ -150,7 +153,10 @@ commands:
- run: set -o pipefail && git checkout stash -- . && git status
- run: set -o pipefail && git add packages/*/dist --force && git status
- run: set -o pipefail && npm run change-package-refs:release
- run: set -o pipefail && npm run bump-version:<< parameters.channel >> -- << parameters.suffix >>
- when:
condition: << parameters.bump_version >>
steps:
- run: set -o pipefail && npm run bump-version:<< parameters.channel >> -- << parameters.suffix >>
- run: set -o pipefail && git add . && git status
- run: set -o pipefail && git commit --allow-empty -m "<< parameters.message >>" && git status

Expand Down Expand Up @@ -284,6 +290,9 @@ jobs:
merge_topic:
type: boolean
default: true
bump_version:
type: boolean
default: true
steps:
- checkout_install_bootstrap
- run: set -o pipefail && npm run build:release
Expand All @@ -295,6 +304,7 @@ jobs:
to: << parameters.to >>
channel: << parameters.channel >>
merge_topic: << parameters.merge_topic >>
bump_version: << parameters.bump_version >>
- when:
condition: << parameters.push >>
steps:
Expand Down Expand Up @@ -603,6 +613,7 @@ workflows:
channel: latest
push: true
merge_topic: false
bump_version: false

# Asks for manual approval and then publishes from the release branch to npm@latest
# Triggered by push to release branch
Expand Down

0 comments on commit 2bf12e4

Please sign in to comment.