feat(observer-locator): ability to create getter based observer #1750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Resolves #1747
🎫 Issues
At the moment, most of our observer locator are still around the interface
.getObserver(object, key)
. Sometimes this doesnt suffice, as there may be the need to observe more than 1 key at once. One can resolve to a getter property and observe that property, but it's cumbersome and not always appropriate/doable.This PR adds a new overload on the
getObserver
of the observer locator, where it allows the 2nd parameter to be a function, treated as a getter, to be passed in. When a function is passed in the 2nd parameter, a different kind of observer that can deal with getter observation will be used instead.This API also makes it simpler to create higher level API on top, so add a new API
watch
onIObservation
for a common case:⏭ Next Steps
See if other APIs can reuse this
.getObserver(obj, getter)
to remove unnecessary infra as much as possible.