feat(observer-locator): ability to create getter based observer #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AureliaEffect
pushed a commit
that referenced
this pull request
Apr 27, 2023
2.0.0-beta.5 (2023-04-27) **Features:** * **observer-locator:** ability to create getter based observer (#1750) ([ba40b2d](ba40b2d)) * **effect:** add watch ([ba40b2d](ba40b2d)) * **di:** property injection with `resolve` (#1748) ([a22826a](a22826a)) * **aurelia:** ability to inject with `Aurelia` export beside `IAurelia` ([a22826a](a22826a)) **Bug Fixes:** * **plugin-conventions:** ensure esm cjs compat (#1751) ([f808503](f808503)) * **compat-v1:** dont use both writable and getter/setter ([b58f967](b58f967)) **Refactorings:** * **build:** preserve pure annotation for better tree shaking (#1745) ([0bc5cd6](0bc5cd6)) * **router-lite:** alias registrations (#1741) ([f5e7140](f5e7140))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Resolves #1747
🎫 Issues
At the moment, most of our observer locator are still around the interface
.getObserver(object, key). Sometimes this doesnt suffice, as there may be the need to observe more than 1 key at once. One can resolve to a getter property and observe that property, but it's cumbersome and not always appropriate/doable.This PR adds a new overload on the
getObserverof the observer locator, where it allows the 2nd parameter to be a function, treated as a getter, to be passed in. When a function is passed in the 2nd parameter, a different kind of observer that can deal with getter observation will be used instead.This API also makes it simpler to create higher level API on top, so add a new API
watchonIObservationfor a common case:⏭ Next Steps
See if other APIs can reuse this
.getObserver(obj, getter)to remove unnecessary infra as much as possible.