Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add a development entry point #1770

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

bigopon
Copy link
Member

@bigopon bigopon commented Jun 2, 2023

📖 Description

Add a "development" condition in exports to support some platforms like https://esm.sh/#docs
Those platforms that do support it will be able to pick the right dev dist.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #1770 (fe25185) into master (1c9c97c) will increase coverage by 0.02%.
The diff coverage is 96.13%.

@@            Coverage Diff             @@
##           master    #1770      +/-   ##
==========================================
+ Coverage   88.01%   88.04%   +0.02%     
==========================================
  Files         242      242              
  Lines       22555    22549       -6     
  Branches     5163     5161       -2     
==========================================
+ Hits        19852    19853       +1     
+ Misses       2703     2696       -7     
Impacted Files Coverage Δ
packages/runtime-html/src/renderer.ts 88.52% <ø> (ø)
...me-html/src/resources/value-converters/sanitize.ts 11.11% <0.00%> (-11.12%) ⬇️
packages/runtime-html/src/utilities.ts 96.87% <ø> (-0.10%) ⬇️
packages/runtime/src/observation/dirty-checker.ts 96.72% <ø> (ø)
.../src/resources/binding-behaviors/update-trigger.ts 75.00% <75.00%> (-1.48%) ⬇️
packages/runtime-html/src/utilities-dom.ts 88.88% <85.71%> (-1.12%) ⬇️
...ntime-html/src/templating/controller.projection.ts 92.75% <87.50%> (-0.40%) ⬇️
packages/runtime-html/src/templating/children.ts 86.86% <92.85%> (+2.40%) ⬆️
packages/runtime-html/src/templating/controller.ts 88.45% <95.00%> (+0.26%) ⬆️
...ges/runtime-html/src/compiler/template-compiler.ts 97.78% <96.00%> (+0.11%) ⬆️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bigopon bigopon merged commit 69ff445 into master Jun 2, 2023
24 checks passed
@bigopon bigopon deleted the feat/development-entry branch June 2, 2023 23:46
@3cp
Copy link
Member

3cp commented Jun 5, 2023

Interesting Node is still adding more and more fields into package.json.
Those fields affect module resolution. This is one of the complexities that Deno decided to get ride of from day 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants