Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime): cleanup, extract error to const enums #1775

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

bigopon
Copy link
Member

@bigopon bigopon commented Jun 13, 2023

📖 Description

  • fix an issue with kernel package types where private properties are not marked as internal causing build errors in libs.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1775 (29f5b1d) into master (99a6191) will increase coverage by 0.00%.
The diff coverage is 69.23%.

@@           Coverage Diff           @@
##           master    #1775   +/-   ##
=======================================
  Coverage   88.40%   88.41%           
=======================================
  Files         244      245    +1     
  Lines       22338    22307   -31     
  Branches     5172     5172           
=======================================
- Hits        19749    19722   -27     
+ Misses       2589     2585    -4     
Impacted Files Coverage Δ
packages/runtime/src/binding/ast.visitor.ts 30.67% <ø> (ø)
packages/runtime/src/binding/connectable.ts 90.38% <0.00%> (ø)
packages/runtime/src/observation.ts 91.66% <ø> (ø)
packages/runtime/src/observation/array-observer.ts 99.39% <ø> (ø)
...time/src/observation/collection-length-observer.ts 72.50% <0.00%> (ø)
...kages/runtime/src/observation/computed-observer.ts 90.78% <0.00%> (ø)
packages/runtime/src/observation/dirty-checker.ts 96.72% <ø> (ø)
packages/runtime/src/observation/map-observer.ts 92.59% <ø> (ø)
packages/runtime/src/observation/observable.ts 95.77% <0.00%> (ø)
...ckages/runtime/src/observation/proxy-decorators.ts 100.00% <ø> (ø)
... and 15 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bigopon bigopon merged commit 07689bf into master Jun 13, 2023
28 of 30 checks passed
@bigopon bigopon deleted the chore/cleanup-9 branch June 13, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant