Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router-lite): URL generation in child component #1778

Merged
merged 4 commits into from
Jun 14, 2023
Merged

fix(router-lite): URL generation in child component #1778

merged 4 commits into from
Jun 14, 2023

Conversation

Sayan751
Copy link
Contributor

Pull Request

πŸ“– Description

🎫 Issues

Fixes #1776

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

⏭ Next Steps

@codecov
Copy link

codecov bot commented Jun 14, 2023 •
edited

Codecov Report

Merging #1778 (7ccfb5a) into master (07689bf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1778   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         245      245           
  Lines       22307    22322   +15     
  Branches     5172     5179    +7     
=======================================
+ Hits        19722    19737   +15     
  Misses       2585     2585
Impacted Files Coverage Ξ”
packages/router-lite/src/instructions.ts 87.26% <100.00%> (+0.96%) ⬆️
packages/router-lite/src/resources/load.ts 88.05% <100.00%> (ΓΈ)
packages/router-lite/src/router.ts 96.19% <100.00%> (ΓΈ)
packages/router-lite/src/viewport-agent.ts 85.20% <100.00%> (ΓΈ)

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sayan751 Sayan751 merged commit fd4de06 into master Jun 14, 2023
26 checks passed
@Sayan751 Sayan751 deleted the topic/router-lite/aboslute-url-for-child-routes branch June 14, 2023 20:26
Sayan751 added a commit that referenced this pull request Jun 15, 2023
@Sayan751
fix(router-lite): hash compatibility with v1
d870caa 
This commit makes the URL hash compatible with Au1. This has been reported here: https://discourse.aurelia.io/t/url-fragment-hash-difference-between-router-lite-and-router/5176.

Additionally, it also addresses the review comments from #1778
@Sayan751 Sayan751 mentioned this pull request Jun 15, 2023
Merged
Sayan751 added a commit that referenced this pull request Jun 16, 2023
@Sayan751
fix(router-lite): hash compatibility with v1 (#1779)
9302db5 
This commit makes the URL hash compatible with Au1. This has been reported here: https://discourse.aurelia.io/t/url-fragment-hash-difference-between-router-lite-and-router/5176.

Additionally, it also addresses the review comments from #1778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigopon bigopon bigopon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[router-lite] Open in new tab does not grab correct url
2 participants
@Sayan751 @bigopon