Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-lite): excluded redirectTo from nav-model #1816

Merged
merged 3 commits into from Oct 6, 2023

Conversation

Sayan751
Copy link
Contributor

Pull Request

πŸ“– Description

🎫 Issues

Closes #1815

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

⏭ Next Steps

@Sayan751 Sayan751 linked an issue Sep 27, 2023 that may be closed by this pull request
@Sayan751 Sayan751 marked this pull request as draft September 27, 2023 18:45
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1816 (51ea6be) into master (de79aea) will decrease coverage by 3.82%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1816      +/-   ##
==========================================
- Coverage   88.55%   84.74%   -3.82%     
==========================================
  Files         248      234      -14     
  Lines       22333    21846     -487     
  Branches     5199     5127      -72     
==========================================
- Hits        19778    18514    -1264     
- Misses       2555     3332     +777     
Files Coverage Ξ”
packages/router-lite/src/route-context.ts 92.77% <100.00%> (ΓΈ)
packages/router-lite/src/route-tree.ts 88.47% <100.00%> (-1.09%) ⬇️
packages/router-lite/src/router.ts 96.18% <100.00%> (+0.01%) ⬆️

... and 64 files with indirect coverage changes

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sayan751 Sayan751 marked this pull request as ready for review October 4, 2023 19:02
package.json Show resolved Hide resolved
@Sayan751 Sayan751 merged commit 085a491 into master Oct 6, 2023
25 of 26 checks passed
@Sayan751 Sayan751 deleted the 1815-bug-redirectto-in-navigationmodel branch October 6, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: redirectTo in navigationModel
2 participants