Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development subpath to package exports (#1856) #1858

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

mxjp
Copy link
Contributor

@mxjp mxjp commented Dec 15, 2023

Pull Request

πŸ“– Description

This adds a "./development" subpath to all packages under "/packages" so that dev builds can be directly imported in nodejs without using a bundler:

import { ... } from "@aurelia/runtime/development";

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

⏭ Next Steps

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (010a4ad) 88.55% compared to head (a5a0469) 88.55%.
Report is 59 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1858   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files         248      248           
  Lines       22290    22290           
  Branches     5180     5180           
=======================================
  Hits        19739    19739           
  Misses       2551     2551           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@bigopon bigopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mxjp

@bigopon bigopon merged commit 91b7daa into aurelia:master Dec 15, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants