Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(attr-mapping): corrected typo #1865

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

Sayan751
Copy link
Contributor

Pull Request

πŸ“– Description

Corrected a residual change from #1864.

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

⏭ Next Steps

@Sayan751 Sayan751 mentioned this pull request Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (010a4ad) 88.55% compared to head (6de5c21) 88.56%.
Report is 64 commits behind head on master.

Files Patch % Lines
packages/route-recognizer/src/index.ts 98.07% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1865   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files         248      248           
  Lines       22290    22334   +44     
  Branches     5180     5198   +18     
=======================================
+ Hits        19739    19780   +41     
- Misses       2551     2554    +3     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@Sayan751 Sayan751 merged commit c5750de into master Dec 30, 2023
28 checks passed
@Sayan751 Sayan751 deleted the topic/1297-attribute-mapper-docs-correction branch December 30, 2023 07:48
@bigopon
Copy link
Member

bigopon commented Dec 30, 2023

Its a bit subtle (unexpected case) but maybe itll do for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants