Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TemplateCompiler): properly startup compilation with <template/> #214

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

bigopon
Copy link
Member

@bigopon bigopon commented Oct 9, 2018

This is to align with vCurrent behavior.
resolves #201

@codeclimate
Copy link

codeclimate bot commented Oct 9, 2018

Code Climate has analyzed commit 3a8b866 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.5% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #214 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   90.08%   90.09%   +0.01%     
==========================================
  Files          83       83              
  Lines        6744     6745       +1     
  Branches     1132     1133       +1     
==========================================
+ Hits         6075     6077       +2     
+ Misses        669      668       -1
Impacted Files Coverage Δ
packages/jit/src/template-compiler.ts 95.34% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e804a0...3a8b866. Read the comment docs.

Copy link
Member

@fkleuver fkleuver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EisenbergEffect EisenbergEffect merged commit c74a44c into master Oct 9, 2018
@EisenbergEffect EisenbergEffect deleted the fix-jit branch October 9, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element with only surrogate behavior gets compiled incorrectly
3 participants