Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): type definition #708

Merged
merged 3 commits into from Oct 15, 2019
Merged

fix(i18n): type definition #708

merged 3 commits into from Oct 15, 2019

Conversation

Sayan751
Copy link
Contributor

Pull Request

📖 Description

Exported I18N interface so that devs don't have to explicitly refer to I18NService.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

⏭ Next Steps

Exported I18N interface so that devs don't have to explicitly
refer to I18NService.
@Sayan751 Sayan751 added this to the Au2 v0.4.0 milestone Oct 13, 2019
@codeclimate
Copy link

codeclimate bot commented Oct 13, 2019

Code Climate has analyzed commit 137ceb9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.4% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #708 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         163      163           
  Lines       13960    13960           
  Branches     2776     2776           
=======================================
  Hits        11297    11297           
  Misses       2663     2663
Impacted Files Coverage Δ
packages/i18n/src/t/translation-binding.ts 90.08% <ø> (ø) ⬆️
packages/i18n/src/t/translation-value-converter.ts 100% <100%> (ø) ⬆️
packages/i18n/src/i18n.ts 100% <100%> (ø) ⬆️
...kages/i18n/src/rt/relative-time-value-converter.ts 100% <100%> (ø) ⬆️
...kages/i18n/src/nf/number-format-value-converter.ts 100% <100%> (ø) ⬆️
...ackages/i18n/src/df/date-format-value-converter.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c4ce2...137ceb9. Read the comment docs.

@fkleuver fkleuver merged commit 64332d4 into master Oct 15, 2019
@fkleuver fkleuver deleted the fix/i18n-typings branch October 15, 2019 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants