feat(observable): add propertyName argument

aurelia · Sep 2, 2016 · e7825eb · e7825eb
1 parent 044746f
commit e7825eb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/decorator-observable.js b/src/decorator-observable.js
@@ -34,7 +34,7 @@ export function observable(targetOrConfig: any, key: string, descriptor?: Proper
       let oldValue = this[innerPropertyName];
       this[innerPropertyName] = newValue;
       if (this[callbackName]) {
-        this[callbackName](newValue, oldValue);
+        this[callbackName](newValue, oldValue, key);
       }
     };
 

diff --git a/test/decorator-observable.spec.js b/test/decorator-observable.spec.js
@@ -14,7 +14,7 @@ describe('observable decorator', () => {
     spyOn(instance, 'valueChanged');
 
     instance.value = newValue;
-    expect(instance.valueChanged).toHaveBeenCalledWith(newValue, oldValue);
+    expect(instance.valueChanged).toHaveBeenCalledWith(newValue, oldValue, 'value');
   });
 
   it('should call valueChanged when changing the undefined property', () => {
@@ -25,7 +25,7 @@ describe('observable decorator', () => {
     spyOn(instance, 'valueChanged');
 
     instance.value = newValue;
-    expect(instance.valueChanged).toHaveBeenCalledWith(newValue, undefined);
+    expect(instance.valueChanged).toHaveBeenCalledWith(newValue, undefined, 'value');
   });
 
   it('should call customHandler when changing the property', () => {
@@ -36,7 +36,7 @@ describe('observable decorator', () => {
     spyOn(instance, 'customHandler');
 
     instance.value = newValue;
-    expect(instance.customHandler).toHaveBeenCalledWith(newValue, oldValue);
+    expect(instance.customHandler).toHaveBeenCalledWith(newValue, oldValue, 'value');
   });
 
   it('should call customHandler when changing the undefined property', () => {
@@ -47,7 +47,7 @@ describe('observable decorator', () => {
     spyOn(instance, 'customHandler');
 
     instance.value = newValue;
-    expect(instance.customHandler).toHaveBeenCalledWith(newValue, undefined);
+    expect(instance.customHandler).toHaveBeenCalledWith(newValue, undefined, 'value');
   });
 
   it('should work when valueChanged is undefined', () => {
@@ -81,7 +81,7 @@ describe('observable decorator', () => {
     spyOn(instance, 'valueChanged');
 
     instance.value = newValue;
-    expect(instance.valueChanged).toHaveBeenCalledWith(newValue, oldValue);
+    expect(instance.valueChanged).toHaveBeenCalledWith(newValue, oldValue, 'value');
   });
 
   it('should work with decorators function when property is undefined', () => {
@@ -92,7 +92,7 @@ describe('observable decorator', () => {
     spyOn(instance, 'valueChanged');
 
     instance.value = newValue;
-    expect(instance.valueChanged).toHaveBeenCalledWith(newValue, undefined);
+    expect(instance.valueChanged).toHaveBeenCalledWith(newValue, undefined, 'value');
   });
 
   it('should work with decorators function and config', () => {
@@ -106,6 +106,6 @@ describe('observable decorator', () => {
     spyOn(instance, 'customHandler');
 
     instance.value = newValue;
-    expect(instance.customHandler).toHaveBeenCalledWith(newValue, oldValue);
+    expect(instance.customHandler).toHaveBeenCalledWith(newValue, oldValue, 'value');
   });
 });