Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
favicon.ico files are all broken #688
I'm submitting a bug report
Please tell us about your environment:
I cannot view the files locally.
Browser also reports the file has error when viewing deployed app.
These are the files location in cli source code. One of the favicon.ico is copied to app root directory when
The favicon.ico in the bootstrapped app can not be viewed in any tool.
Manual visit at http://localhost:9000/favicon.ico yields broken file. Firefox says cannot be displayed because it has errors.
Thanks for the invitation. But I am too lazy for a PR, not that obsessed to show my name in the git log.
It would be easier for you to just commit directly.
Need to add
Note, the existing broken favicons are png format too, but they are still broken png files.
referenced this issue
Aug 12, 2017
@JeroenVinke this issue need to be reopened.
App created by cli still has broken
The real issue is
That line then use
To process all files in
The result is copied
We need another api on ProjectItem to support copying binary file which should use default encoding