New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack setup .babelrc.js probably used useBuiltIns wrongly #909

Closed
huochunpeng opened this Issue Jul 29, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@huochunpeng
Member

huochunpeng commented Jul 29, 2018

Current webpack .babelrc.js set userBuiltIns to true

module.exports = () => {
  return {
    // ...
    "presets": [
      [
        "env", {
          // ...
          "useBuiltIns": true
        }
      ]
    ]
  }
}

But preset-env's useBuitIns only has three options: "usage", "entry", or false.

babel/babel#6830
https://babeljs.io/docs/en/next/babel-preset-env.html#usebuiltins

I suspect the current "useBuiltIns": true has same effect as "useBuiltIns": false.

huochunpeng added a commit to huochunpeng/cli that referenced this issue Jul 29, 2018

feat: upgrade to babel-preset-env
Unify babelrc for webpack and cli bundler.
Cleaned up webpack babelrc to use same plugins as other setup.
Add IE10/11 support back to webpack setup as that is what Aurelia claimed to support.

closes aurelia#754, aurelia#909

huochunpeng added a commit to huochunpeng/cli that referenced this issue Aug 18, 2018

feat: upgrade to babel-preset-env
Unify babelrc for webpack and cli bundler.
Cleaned up webpack babelrc to use same plugins as other setup.
Add IE10/11 support back to webpack setup as that is what Aurelia claimed to support.

closes aurelia#754, aurelia#909

huochunpeng added a commit to huochunpeng/cli that referenced this issue Aug 18, 2018

feat: upgrade to babel-preset-env
Unify babelrc for webpack and cli bundler.
Cleaned up webpack babelrc to use same plugins as other setup.
Add IE10/11 support back to webpack setup as that is what Aurelia claimed to support.

closes aurelia#754, aurelia#909

@huochunpeng huochunpeng closed this Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment