Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify if "detached" is fired before or after removal from the DOM #250

Closed
wichert opened this issue Jul 27, 2016 · 2 comments · Fixed by aurelia/framework#871
Closed

Clarify if "detached" is fired before or after removal from the DOM #250

wichert opened this issue Jul 27, 2016 · 2 comments · Fixed by aurelia/framework#871
Labels
documentation

Comments

@wichert
Copy link

wichert commented Jul 27, 2016

Currently the documentation says "At some point in the future, the component may be removed from the DOM. If/When this happens, and if the view-model has a detached callback, this is when it will be invoked.". From that it is not clear if detached is fired just before, or just after the component is removed form the DOM.
@EisenbergEffect
Copy link
Contributor

It is fired after removal from the dom. Would you be interested in submitting a PR to update the document with this clarification?

This was referenced Mar 2, 2018
Closed
Merged
@Alexander-Taran
Copy link
Contributor

please review pr to docs about detached()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(doc): clarify when detached() is called
3 participants
@EisenbergEffect @wichert @Alexander-Taran