Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurelia validation docs - configuration in .json still needed? #438

Closed
GimmeDaKitty opened this issue Jul 11, 2019 · 1 comment · Fixed by #439
Closed

Aurelia validation docs - configuration in .json still needed? #438

GimmeDaKitty opened this issue Jul 11, 2019 · 1 comment · Fixed by #439

Comments

@GimmeDaKitty
Copy link

Hi!
I am checking out the documentation regarding validation ,and after installation of the aurelia-validation package the instruction reads:

If you're using the aurelia-cli, add the following configuration to your aurelia.json after you've installed the package with npm.

 {
    "name": "aurelia-validation",
    "path": "../node_modules/aurelia-validation/dist/amd",
    "main": "aurelia-validation"
  }

[...] search your aurelia.json for aurelia-templating-resources [...]

The aurelia.json file under the aurelia_project does not have anything about aurelia-template-resources. It looks like this template-resources is now part of the packages.json file.

Is the documentation still up to date?

My setup:
Library Version:
aurelia-cli v1.0.1
Environment

Operating System:
Windows 10

Node Version:
v10.15.3

NPM Version:
6.9.0

Browser:
Chrome Version 75.0.3770.100 (Official Build) (32-bit)

Language:
Typescript 3.1

Loader/bundler:
Webpack

@3cp
Copy link
Member

3cp commented Jul 11, 2019

It is outdated, latest cli doesn't require user to add dep explicitly. CLI does all automatically.

I will remove the part from the doc.

3cp added a commit to 3cp/documentation that referenced this issue Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants