Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

't-params' attribute cannot be renamed #41

Closed
RichTeaTime opened this issue Dec 3, 2015 · 5 comments
Closed

't-params' attribute cannot be renamed #41

RichTeaTime opened this issue Dec 3, 2015 · 5 comments

Comments

@RichTeaTime
Copy link

I don't want to use the 't' attribute for i18n, so have specified I18N.setup({ attributes:['i18n'] }); in my aurelia plugin initialisation.

However, if I want to use the 'attribute param' syntax, I can only currently use 't-params', e.g.
<div i18n="token" t-params="value" />
I want to be able to do
<div i18n="token" i18n-params="value" />

This seems pretty simple to add, just an extra registerAttribute in I18N.configure.
For example: https://github.com/RichTeaTime/i18n
and would make the behaviour consistent when specifying custom attribute names.

@zewa666
Copy link
Member

zewa666 commented Dec 3, 2015

good catch. since you've done already the great work may I ask you to sign our CLA and create a PR with the changes?

@zewa666
Copy link
Member

zewa666 commented Jan 4, 2016

@RichTeaTime ping

@RichTeaTime
Copy link
Author

Sorry, was otherwise engaged. Also a complete noob at git, but will get the PR created asap.

@RichTeaTime
Copy link
Author

Pull Request #53

zewa666 added a commit that referenced this issue Jan 7, 2016
 foreach attribute registered, add the corresponding *-params attribute as well

 fixes issue #41
@zewa666
Copy link
Member

zewa666 commented Jan 7, 2016

@RichTeaTime thanks for the contribution, its merged and will be ready with the next release

@zewa666 zewa666 closed this as completed Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants