Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dependency on core-js. #20

Closed
wants to merge 1 commit into from
Closed

Adds dependency on core-js. #20

wants to merge 1 commit into from

Conversation

MicahZoltu
Copy link

If you don't directly depend on core-js (which the skeleton app does) then aurelia-loader will fail to load because it can't find core-js. I was able to work around this by manually telling SystemJS that aurelia-loader depends on core-js, but as a user I shouldn't have to do that.

If you don't directly depend on `core-js` (which the skeleton app does) then `aurelia-loader` will fail to load because it can't find `core-js`.  I was able to work around this by manually telling SystemJS that `aurelia-loader` depends on `core-js`, but as a user I shouldn't have to do that.
@MicahZoltu
Copy link
Author

https://github.com/aurelia/loader/blob/master/src/loader.js#L2 suggests that this module definitely depends on core-js.

@MicahZoltu
Copy link
Author

Workaround:
package.json

{
  "jspm": {
    "overrides": {
      "npm:aurelia-loader@1.0.0-beta.1": {
        "dependencies": {
          "aurelia-metadata": "^1.0.0-beta.1",
          "aurelia-path": "^1.0.0-beta.1",
          "core-js": "^1.2.6"
        }
      }
    }
  }
}

MicahZoltu added a commit to Zoltu/RepoCreator-Client that referenced this pull request Dec 23, 2015
@EisenbergEffect
Copy link
Contributor

After looking over the code, I can't find anywhere where this module actually needs things provided by core-js in order to function. So, instead of officially adding the core-js dependency, I remove the core-js import statement.

@MicahZoltu
Copy link
Author

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants