fix: Apply ISP to improve code flexibility. #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the logger type from
Logger
to simply{ id: string }
.This is what's need by the
ConsoleAppender
and reduce the unnecessary coupling between theAppender
and theLogger
.This allows the
Appender
to improve and use independently of theLogger
.This change follows the Interface Segregation Principle to declare and consume only what you need.
As such, the
aurelia-logging
dependency is moved to devDependency.