-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate event from Child routers instead of root router #293
Comments
Same issue here. Are there any updates on this ? |
It sounds like we can add this pretty easily. Would anyone care to spec it out and provide a few more implementations details? |
Same issue. The aurelia-google-analytics plugin needs the route's title to send data, but the events raised from the child router navigation doesn't include this information. @miguelzakharia |
I have the same issue here. I like to receive the child router route config which is currently active. Here an example: Given: Then: Expect: I think only the currently active router should fire events. This should be implemented for all events:
|
I found a solution for my use case. To get the setting of a child router route i can call |
maybe can be closed? |
@EisenbergEffect added to vNext router use cases. |
We currently have EventAggregator events raised for the router, but these are generated from and refer to the root router only.
When creating global actions relating to routers (such as context sensitive information, such as discussed in #281, we need routing information from the children too.
Given that we can easily walk up the chain of routers, it makes sense that the raised events include the information as to which is the final router instance involved in the route, as this contains all of the
params
from the current and parent route variables.The only current workaround (I could find) is to add a method to the
activate(params)
of every VM and raise the event there.The text was updated successfully, but these errors were encountered: