Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Sourcemaps relative path doesn't work if modules are inside subfolders #111

Closed
benib opened this issue Jun 24, 2015 · 2 comments
Closed

Comments

@benib
Copy link

benib commented Jun 24, 2015

Commit aaf3cc9 introduced relative sourceMap URLs. This is a problem if there are modules inside subfolders.

I don't see a very good solution, that's why this is only an issue and not a PR.

I think having absolute URLs for the sourceMaps is the better option here, as they are probably mostly used during development, and then we can use gulp watch to have a webserver with the correct root.

Any other suggestions are very welcome.

@EisenbergEffect
Copy link
Contributor

@AshleyGrant I think you created the original PR to make them relative. Can you provide some feedback on this?

AshleyGrant added a commit to AshleyGrant/skeleton-navigation that referenced this issue Jun 24, 2015
AshleyGrant added a commit to AshleyGrant/skeleton-navigation that referenced this issue Jun 24, 2015
@AshleyGrant
Copy link
Collaborator

@benib I've created a PR #113 to switch to inlining the source in source maps. This should resolve any further issues as it is the recommended way to handle source maps. I tested it using modules in sub folders as well as when serving the site from a folder that isn't the server base.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants