New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slot leak #677
Fix slot leak #677
Conversation
When a test fails under Karma the console stacktrace contains incorrect line numbers making debugging impossible. Applying fix manually as described in chriscasola/karma@67d1cfe closes aurelia#670
This reverts commit ea994d1.
038d8b1
to
8224465
Compare
|
…rkaround test setup issue
3aedfd1
to
77f60a9
Compare
@fkleuver @EisenbergEffect @StrahilKazlachev ready for review |
@bigopon I've not been active for some time, so are dist files added now with the PRs? |
@StrahilKazlachev its because the target branch is develop and the pr is based on master. The commits that contain those dist should ideally ve in develop already. Cc @fkleuver |
resolved by #678 |
Fixes aurelia/templating-resources/issues/392
Thanks to @thomas-darling for this fix.
Currently,
ShadowSlot
keeps track of whatNode
has been projected through it, via an internalchildren
array but it doesn't untrack(remove) those trackedNode
from the array when the owning views of thoseNode
s get removed. Fix this by removing them inShadowSlot.prototype.removeView
andShadowSlot.prototype.removeAll
Also revamp testing setup so that it can remove the usage of jspm for testing, while keeping the build process intact. Now we have:
npm run test npm run test:watch npm run test:debugger
with an option to go full integration tests to have more solid infra for tricky parth such as Shadow DOM emulation.
@EisenbergEffect @fkleuver @StrahilKazlachev