New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For issue #170 type script improvements #171
For issue #170 type script improvements #171
Conversation
…tter aurelia-validation.d.ts This commit includes initial work from @stephenlautier and my fixes/improvements mentioned in his pull request https://github.com/aurelia/validation/pull/162/files as well other my own improvements on that matter for other methods.
Forgot to mention, that I've signed the CLA. @stephenlautier I hope it is OK for You, that I included Your commits (mentioned You and added references to Your original commits to avoid "taking the glory" from You). Could You please confirm that this is OK for You so this pull request could be merged without any legal problems? |
This includes 3 pull requests in addition to version 0.3.1: 1) aurelia#166 - aurelia#167 - TypeError: Cannot read property 'classList' of null 2) aurelia#168 - aurelia#169 - makes TWBootstrapViewStrategyBase reusable 3) aurelia#170 - aurelia#171 - Improve generated TypeScript declarations
Noooess... my first contribution to this awesome project! Kidding :). Sure go ahead, thanks for the comments. As I stated in some of my type defs I updated mainly what I was more confident about hence that's why I set some of them to any (to not break anyone else by using wrong types or anything). Cheers 👍 |
…le to download custom package with jspm from my repo). This includes 3 pull requests in addition to version 0.3.1: 1) aurelia#166 - aurelia#167 - TypeError: Cannot read property 'classList' of null 2) aurelia#168 - aurelia#169 - makes TWBootstrapViewStrategyBase reusable 3) aurelia#170 - aurelia#171 - Improve generated TypeScript declarations
thanks @stephenlautier for Your contribution and permission to include Your work in this pull request!
Actually I'm also doing just that (or looking up smth from the source if documentation doesn't say enough).
When writing real TypeScript I've found it really disturbing when I see |
Ahh I understand your point. Personally it doesn't bother me much, especially even when contributing to definitely typed they use
So you always have to give it a type, even when you don't know it. Generally when I see |
Please merge this pull request and run
gulp build
to update dist folder.This pull request improves generated TypeScript declarations (see #170).
This pull request includes initial work from @stephenlautier (see commit stephenlautier@1ea917b and stephenlautier@7a5eb63) and my fixes/improvements mentioned in his pull request https://github.com/aurelia/validation/pull/162/files as well other my own improvements on that matter for other methods.