fix: add namespace to get all for pinecone

[jamescalam]

PR Type

bug_fix

---

Description

• The PR adds a condition to include the namespace in the request parameters for the _get_all method in the Pinecone router. This ensures that the namespace is considered when fetching all vectors.

---

Changes walkthrough 📝

	Relevant files
Enhancement	pinecone.py Include Namespace in API Request Parameters                            semantic_router/index/pinecone.py Added a condition to include namespace in the request parameters if it is set. +2/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Description updated to latest commit (80bcc4a)

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the PR involves a small change in a single file and the logic added is straightforward. The change is limited to adding a condition to include an additional parameter in an API request.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The condition if self.namespace: assumes that self.namespace is either truthy or falsy. If self.namespace can be an empty string or zero which are valid values, this condition might incorrectly exclude them.
🔒 Security concerns	No

Code feedback:

---

relevant file	semantic_router/index/pinecone.py
suggestion	Consider checking for None explicitly when adding the namespace to the parameters. This avoids excluding valid falsy values like empty strings or zeros. Use if self.namespace is not None: to ensure all valid values are included. [important]
relevant line	if self.namespace:

---

[github-actions]

PR Code Suggestions ✨

Category	Suggestions
Enhancement	Ensure namespace is non-empty before adding to parameters. Consider checking if self.namespace is not only present but also non-empty before adding it to the params dictionary. This helps avoid sending unnecessary or invalid parameters in the request. semantic_router/index/pinecone.py [191-192] -if self.namespace: +if self.namespace and self.namespace.strip(): params["namespace"] = self.namespace

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.31%. Comparing base (a4404fa) to head (80bcc4a).

Files	Patch %	Lines
semantic_router/index/pinecone.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   80.37%   80.31%   -0.07%     
==========================================
  Files          44       44              
  Lines        2441     2443       +2     
==========================================
  Hits         1962     1962              
- Misses        479      481       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.